Remove dead jsonLimitForPath abstraction
From the PR description
jsonLimitForPath() ignores its path argument and always returns "50mb", and the per-request wrapper re-invokes express.json() on every request for no effect. This replaces both with a single static express.json({ limit: "50mb" }) mount.
- Behaviour identical, one insertion, seven deletions
npm run buildpasses; full vitest suite passes (259 passed, 5 skipped)- If per-path body limits are wanted later (which the function's shape suggests was the original intent), happy to implement that properly against an explicit route list
Found while reading the codebase for our fork work (b1rdmania).
🤖 Generated with Claude Code
Our analysis
Simplify JSON body parsing — read the full analysis →
Think the analysis missed something the PR description covers?
Commits in this PR (3)
| SHA | Subject | Author | Date | |
|---|---|---|---|---|
ef80cc70 | Remove dead jsonLimitForPath abstraction | b1rdmania | 2026-07-29 | ↗ GitHub |
commit bodyjsonLimitForPath() ignores its path argument and always returns "50mb", and the per-request middleware wrapper re-invokes express.json() on every request for no effect. Replace with a single static express.json() mount. Behaviour is identical; if per-path body limits are wanted later, happy to implement them properly against a list of routes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> | ||||
8206df51 | Name the JSON body limit constant | Andy | 2026-07-31 | ↗ GitHub |
Per review: a named constant reads better than a bare string at the mount site, and gives the value somewhere to be documented. | ||||
435b27d9 | docs: clarify JSON body limit scope | willchen96 | 2026-08-03 | ↗ GitHub |
Capture this PR into my fork
Download a Markdown prompt that tells Claude how to port every
commit in this PR into your working tree. Run it via
claude -p < capture-pull-273.md from
inside the repo you want the changes in.