[Testing 08] test: route-level integration tests + real-Supabase auth/RLS suites
From the PR description
Summary
Route-level integration tests for the API - 94 tests across chat, projects, project-chat, tabular, user, document-upload and health routes, plus two env-gated suites that exercise the real Supabase stack (auth contract, deny-all RLS, cross-tenant isolation). Ported from the amal66 fork (reference index #205) and adapted to this repo's routes/ layout. Stacks on #228 (vitest harness).
Changes
- One mechanical production change:
backend/src/index.tsis split intoapp.ts(builds and exports the express app - the old file verbatim minus the listen call) and a tinyindex.tsthat imports it and listens. Same middleware order, same limiters, same log line;npm run buildand thestartscript are unchanged. This is the standard seam supertest needs. backend/src/__tests__/integration/- mocked-Supabase suites: health (5), chat (6), projects (18), projectChat (3), tabular (31), user (27), documentsUpload (4). Coverage priorities: 401s for unauthenticated requests, ownership/authorization (user A cannot touch user B's resources), input validation, and happy paths.- Env-gated real-stack suites (skip cleanly unless
SUPABASE_TEST_URL/SUPABASE_TEST_SERVICE_ROLE_KEYare set):access.supabase.test.ts(shared-project document filtering drops foreign document IDs) andstack.supabase.test.ts(GoTrue↔API auth contract, deny-all RLS on public tables, tenant isolation, service-key leak sweep).scripts/test-stack.sh+npm run test:stackread the keys fromsupabase statusautomatically. supertest+@types/supertestdev-dependencies.
Why
The e2e suite (#220) proves the flows through a browser; nothing proves the API's authorization boundaries directly. For a product holding privileged legal documents, "user A cannot read user B's project" deserves a test that runs in seconds on every PR - and the RLS/auth contract deserves a suite you re-run on every Supabase bump.
What was deliberately not ported
Fork-only feature suites (orgs, credits, DMS connectors) and cases tied to fork-only behavior (credit reservation, upload magic-byte sniffing, download-zip doc cap). Two of those absences are worth flagging as hardening gaps here: uploads are validated by extension only (no content sniffing), and download-zip has no document-count cap. Happy to raise either as its own PR.
Testing
npm test --prefix backend- 8 files passed, 2 skipped (the gated ones without env); 106 passed, 5 skipped, 0 failed.- With a local Supabase running:
npm run test:stack --prefix backend- 5/5 passed live. npm run build --prefix backend- passes.
Includes #228's commit as its base until proper stacking is possible - review the top commit only.
🤖 Generated with Claude Code
Our analysis
Add API authorization integration tests — read the full analysis →
Think the analysis missed something the PR description covers?
Commits in this PR (5)
| SHA | Subject | Author | Date | |
|---|---|---|---|---|
45a4f750 | test: route-level integration tests + app/index split | QA Runner | 2026-07-20 | ↗ GitHub |
commit bodyPorts the backend route-level integration suites from the amal66 fork
(index: Open-Legal-Products/mike#205), adapted from the fork's
apps/api modules/services layout to this repo's monolithic
backend/src/routes/*.ts layout.
app/index split (the only production change; mechanical, zero behavior
change): backend/src/index.ts previously built the express app and
called app.listen at the bottom. Everything except the listen call
moved verbatim into backend/src/app.ts, which now exports `app` (same
middleware order, same routes, same rate-limiter setup, dotenv/config
still imported first). index.ts is now a tiny entry that imports
{ app } and calls listen with the same log line. `npm run build` still
emits dist/index.js and the `start` script is unchanged.
New suites under backend/src/__tests__/integration/ (94 tests):
- health.test.ts (5): /health, requireAuth 401 paths, 404 fallthrough
- chat.routes.test.ts (6): POST /chat validation + SSE happy/error paths
- projects.routes.test.ts (18): overview/create/detail/patch/delete,
sharing normalisation, ownership guards
- projectChat.routes.test.ts (3): project access guard + SSE paths
- tabular.routes.test.ts (31): review CRUD, access guards,
document-access filtering, missing_api_key guards
- user.routes.test.ts (27): profile, API-key crypto boundary, MFA
guards, export/deletion endpoints
- documentsUpload.routes.test.ts (4): upload validation + download-zip
bounds/access
- access.supabase.test.ts (1) + stack.supabase.test.ts (4): gated on
SUPABASE_TEST_URL / SUPABASE_TEST_SERVICE_ROLE_KEY (stack suite also
needs SUPABASE_TEST_ANON_KEY); describe.skip otherwise
- scripts/test-stack.sh + `npm run test:stack`: reads a running
`supabase status -o json` and runs the gated suites
Adds supertest + @types/supertest as devDependencies.
Dropped relative to the fork (subjects that do not exist in this repo):
- orgs.routes, credits.concurrency.supabase, dmsConnectors suites
(fork-only features)
- all credit-reservation cases (429 CREDIT_LIMIT_EXCEEDED,
reserve-then-refund) in chat/projectChat: no credit system here
- health /ready case: no /ready endpoint here
- org-membership project access case: no org model here
- upload magic-byte validation cases: this repo validates extension
only (the fork adds content sniffing; replaced with a missing-file
400 case)
- download-zip 50-document cap case: no cap here (replaced with a
no-accessible-documents 404 case)
- stack.supabase PUBLIC_TABLES updated to this repo's schema; the
fork's credit-RPC coverage is n/a
Verified locally: backend `npm test` -> 8 files passed, 2 skipped;
106 tests passed, 5 skipped (gated suites skip without env).
`npm run build` passes. The gated suites were additionally run against
a live local Supabase stack: 2 files, 5/5 tests passed.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
| ||||
71a7aba3 | Merge branch 'main' into olp-pr/backend-integration-tests | Will Chen | 2026-07-22 | ↗ GitHub |
6aed350a | fix: repair JSON corrupted by the merge of main (package.json + lockfile) | QA Runner | 2026-07-22 | ↗ GitHub |
commit bodyThe "Merge branch 'main'" commit (71a7aba) auto-merged backend/package.json and backend/package-lock.json without raising a conflict, but git's line-level merge produced invalid JSON in both files: package.json lost the comma after the new "test:stack" script, and package-lock.json lost the two closing-brace lines of the supertest/cookie-signature entry. npm treats an unparseable lockfile as absent, which is why CI failed with the misleading "npm ci can only install with an existing package-lock.json". package.json: restore the comma. package-lock.json: rebuilt from main's known-good copy via `npm install --package-lock-only` against this branch's package.json. Verified locally: npm ci, npm test (259 passed), npm run build. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> | ||||
9399fce8 | fix stack test database initialization | willchen96 | 2026-07-23 | ↗ GitHub |
b2dbb39c | narrow service role schema grants | willchen96 | 2026-07-23 | ↗ GitHub |
Capture this PR into my fork
Download a Markdown prompt that tells Claude how to port every
commit in this PR into your working tree. Run it via
claude -p < capture-pull-233.md from
inside the repo you want the changes in.