Address review of #76: editor key, keyboard guard, column-save rollback
Should-fixes:
- key={id} on TemplateEditor so state re-initialises per template segment
(fixes built-in -> Duplicate -> Back stale content and the post-create
read-only flash)
- stopPropagation on the row actions cell's onKeyDown, so Enter/Space on the
menu trigger opens the menu instead of navigating the row
- column auto-save now snapshots the previous columns and rolls back on
failure with an inline error, mirroring the admin card's pattern
Nits: TemplateRow/Section moved to module scope; Duplicate failures surface
the server detail at both sites; the four flagged error sites use the house
`err instanceof MikeApiError && err.message` pattern so network TypeErrors
never render as user copy; save-notice timer cleared on unmount and replaced
on re-save; "Search templates..." ellipsis.
MFA gating for template admin-revert is out of scope here (follow-up PR); the
admin card copy is unchanged.
Gates: tsc clean; lint 112 problems, identical to stashed baseline; build
clean with both new routes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
| Repository | Sloth-ninja/JessicaOSS |
|---|---|
| Author | sloth-ninja <ezanahaddis@gmail.com> |
| Authored | |
| Parents | d8d88f5a |
| Stats | 7 files changed , +211 , -116 |
| Part of | Firm-shared tabular review templates |
Capture this commit into my fork
Download a Markdown prompt that tells Claude how to port this
exact commit into your working tree. Run it via
claude -p < capture-commit-8f87aa94.md
from inside the repo you want the change in.