WS8 composed-range review: firm-settings minor fixes

↗ view on GitHub · sloth-ninja · 2026-07-27 · 379f3d2d

Fix wave from the multi-lens review of the WS8 train (0646edf...main).
Zero Critical/Important findings survived adversarial verification; the
four Minors all sat in admin/firm-settings/page.tsx:

- Firm API keys: failed status fetch no longer strands a perpetual
  loading skeleton - resolves to an error state with retry.
- All three section fetches (members, firm keys, connector curation)
  gain in-place "Try again" recovery (LoadErrorRow), aligned with the
  Dashboard's ErrorState; load errors tracked separately from mutation
  errors so inline banners keep working.
- Connector curation: block unticking the last connector - an empty
  tick-list would save [] which canonically means "all visible",
  silently inverting the admin's intent. Copy points at the member
  connectors policy instead.
- formatUkDate pins timeZone UTC to match the Dashboard, so dates
  cannot render a day apart across the two admin pages.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Repository Sloth-ninja/JessicaOSS
Author sloth-ninja <ezanahaddis@gmail.com>
Authored
Parents 4cbc8586
Stats 2 files changed , +132 , -23
Part of WS8 minor review fixes + close-out status

Capture this commit into my fork

Download a Markdown prompt that tells Claude how to port this exact commit into your working tree. Run it via claude -p < capture-commit-379f3d2d.md from inside the repo you want the change in.

⬇ Download capture-commit-379f3d2d.md