Delta-review fixes for #74: getTemplate email-share access + hardening nits

↗ view on GitHub · sloth-ninja · 2026-08-05 · 0ca9b8f9

Should-fix: getTemplate gains an optional userEmail param and a
workflow_shares normalised-email match as its third access path - the
shared list bucket was unreachable by id, 404ing the editor/duplicate
flow for sharees. Final signature:
getTemplate(db, userId, id, orgId, userEmail?).

Nits: shared-id lookup chunked at 100 per .in() (414 guard) with
newest-first re-sort; a template both email-shared and firm-visible now
appears in shared only (shared wins); tag values additionally strip
[ ] | (the [[tag]] prompt-marker vocabulary; column names keep the
control-char strip only); the PGRST204/42703 degrade in
setTemplateVisibility/adminRevertTemplate now console.warns with
safeErrorLog; test-file raw control bytes replaced with \u escapes.

Suite 738 green (57 seam + 25 route template tests). BUILD_LOG entry
amended in place.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Repository Sloth-ninja/JessicaOSS
Author sloth-ninja <ezanahaddis@gmail.com>
Authored
Parents e9e7c2b3
Stats 5 files changed , +199 , -39
Part of Firm-shared tabular review templates

Capture this commit into my fork

Download a Markdown prompt that tells Claude how to port this exact commit into your working tree. Run it via claude -p < capture-commit-0ca9b8f9.md from inside the repo you want the change in.

⬇ Download capture-commit-0ca9b8f9.md